Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to choose mode from map #308

Closed
wants to merge 12 commits into from

Conversation

sunil07t
Copy link
Contributor

@sunil07t sunil07t commented Dec 28, 2017

This change allows the user to change the mode of their previous trip. The original sensed mode is not changed, an object mode_confirm is added to the section of the trip. mode_confirm includes the ts, tripId, sectionId, mode value and mode text. The user can change the mode by tapping on the section lineString of the leaflet map. We already have a listener to receive incident of a trip if the user presses on the trip or section lineString. So to make things simple, a button is included in the detail screen to take user to edit mode screen. After the user pick all the modes they can either save or cancel their edit. While editing the lineString does not change color to show the mode, however, there is a temporary marker on the line to show where the user split the trip. After they save the color changes to show the respective modes. Also, the list screen only shows choose mode button for single mode trips.

the mode_confirm object has {end_ts, label, start_ts, trip_mode} keys

Done: Add more colors to represent each mode in the set
Done: Change Detail and List sensed mode icons to mode_confirm mode icon

I was not able to complete the following:
Get the mode_confirm from the server

screen shot 2017-12-28 at 12 19 28 am

screen shot 2017-12-28 at 12 19 55 am

screen shot 2018-01-23 at 8 33 09 pm

screen shot 2018-01-23 at 8 33 36 pm

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants